On Thu, May 9, 2019 at 6:44 PM Christopher Schultz < ch...@christopherschultz.net> wrote:
> -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA256 > > Rémy and Mark, > > On 5/9/19 12:32, Rémy Maucherat wrote: > > On Thu, May 9, 2019 at 4:47 PM Mark Thomas <ma...@apache.org> > > wrote: > > > >> On 09/05/2019 14:38, Rémy Maucherat wrote: > >> > >> <snip/> > >> > >>>> +1 to hard-coding to a single acceptor thread and removing > >>>> the plumbing that supports more than that. > >>> > >>> Ok, done. > >> > >> Great. > >> > >>> So I suppose you prefer keeping the ability to have multiple > >>> poller > >> threads > >>> for NIO ? > >> > >> NIO defaults to 1 anyway. > >> > >> I agree with that multiple Poller threads is unlikely to offer a > >> performance benefit in any realistic scenario. > >> > >> APR only supported multiple Poller threads because of a Windows > >> XP / Server 2003 issue that limited poller size to 1024. Other > >> than that, comments in the APR code indicate a preference for a > >> single Poller. > >> > > > > Yes, I ran into that then ... > > I'm not sure it's okay to drop support for Server 2003 at this point, > is it? Or, I guess we are okay if we drop APR support on Server 2003 ; > NIO will still work just fine, right? > Since it's 100% independent and given the uncertain future of the APR connector, I don't plan to make any changes to APR. > > >> I've no objection to making a similar change to the > >> pollerThreadCount. > > > > Ok, so this is turning into a large refactoring. I'll put it up for > > review first, even though the testsuite looks ok (locally, so it > > means nothing I guess, haha). > > +1 :) > Rémy > > - -chris > -----BEGIN PGP SIGNATURE----- > Comment: Using GnuPG with Thunderbird - https://www.enigmail.net/ > > iQIzBAEBCAAdFiEEMmKgYcQvxMe7tcJcHPApP6U8pFgFAlzUWNoACgkQHPApP6U8 > pFjBcBAAjTiY/fEs/EMzjsd+Q/AtUN6Bs+W86uRZPuK5pRzWNQuKoBVTFNU13bJ7 > 5dXybkDsQrTf3WfBJr68Pznkezr96cQmQmfN2g67hE/AeygHbd7Hn5pwQGMmJOAt > 5bOzTOqaKMYQvif81CUy7S4HCbx4qWXkLmJ7ypfJksvVO7UF/PpdFZKGRlrnkHXb > FzFO9W1ruCnsDrxMud94jbpMTyqCJN1DPu5ra/852UEivN3TKDfh1YeHe+lm190Q > Uff82ELzAQlhkJ8qkHW9xYszmBZmwydozJw86jtTQ+7c4+0RWKcxiUHWfz/W3rez > emy1co6gDJ/PNsz9br6InJHorv6SREBx4TH5F7hPfI6AoYO7nsWKlM5nLsB5P64k > aTK2E6sAOw7+mKIDVEzSraqX8E6KomRHyOfMLDZjRyT9nKP5dyQaRcCBOLfYLTqv > gqJBp7f+IZloSVsJYALmABF0mi/StUsqEan2Y7RFfgsJx6ZYVDQq+QzwXV8etqfK > zMZNPF9L7kUBouF3KAzmi1qlLrmFhBXQ1XGUiUnZAx6BWKmKu3JKLEb+wAe/znb2 > kLSuxgb8YY2PfPK4EGYv+QydM1nwWbyLnx6aVICzXTm4WaPSun8OTV8jdu1t44Kx > DDEFzP62Ayb3nn9rNlW2TPxXd52MHaWCVCvJk0Jre0ji+ES4TP0= > =XCp9 > -----END PGP SIGNATURE----- > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > For additional commands, e-mail: dev-h...@tomcat.apache.org > >
