Hello Rémy, Few precisions inline
Le jeu. 30 mai 2019 à 00:34, Rémy Maucherat <r...@apache.org> a écrit : > Hi, > > On Wed, May 29, 2019 at 11:35 PM Romain Manni-Bucau <rmannibu...@gmail.com> > wrote: > >> Hi Rémy, >> >> Openwebbeans has a tomcat integration module - mainly standalone case, >> and meecrowave subproject - embedded or ready to run fatjar. It looks like >> it covers what you target. Where I am loosing track is why not improving >> openwebbeans and forking the code in tomcat? At least i would expect to >> discuss to move over tomcat the code on dev@owb - and I would support it >> ;). >> > > There's not a lot of code, so I don't call that a fork. The problem is > that I need to make changes and adjustments in Tomcat, so in the end it > can't be in owb. I used the code from webbeans-tomcat7, and didn't see any > other modules (maybe you're referring to the ones in samples I just found). > Once done it can be hosted on both side. Owb has the advantage to be know by users, tomcat to be a more natural home for an integration. At the end it is mainly synchronizing both projects for a consistent communication and code "move" IMHO. For deep tomcat/cxf integration, you can use http://svn.apache.org/repos/asf/openwebbeans/meecrowave/trunk/ - core module. Technically it uses an embedded flavor but it would be easy to move to a standalone one through a listener based on a small refactoring in Meecrowave#start. The good part are the lifecycle and scanning integrations + the tooling to make testing and dev simple - http://openwebbeans.apache.org/meecrowave/. >> More technically: openwebbeans does not need properties files you can >> pass Properties when you create the WebBeansContext, this is what tomee >> does. Same for cxf and its bus ;). >> > > Ok, I'll have a look at that, it's better than properties files (but > similar). > >> Biggest short term challenge is to align scanners but it is very doable, >> long term it is to drop big core jars in all 3 libs for smaller bundles ;). >> > > Ok. > >> >> Feel free to shout if you need help or more precise pointers. >> > > Rémy > >> >> >> Le mer. 29 mai 2019 à 18:26, Rémy Maucherat <r...@apache.org> a écrit : >> >>> Hi, >>> >>> This was on my hackaton todo list, I guess I'm a bit late, but getting >>> to it now ... >>> >>> CDI is the building brick for many other popular libraries and >>> frameworks, including JAX-RS (Apache CXF), Eclipse Microprofile, etc. >>> Looking at the CDI implementation from the ASF, I am not fully satisfied >>> with the integration or packaging of OWB in the context of Tomcat. Since >>> it's such an important building block, I wanted to do something about it >>> and be able to have something that played better with Tomcat standalone, in >>> addition to embedded (that is well covered !). As a result, I took on the >>> task to take over the Tomcat(7 ;) ) integration that was in OWB. >>> >>> I'm working on it here: https://github.com/rmaucher/tomcat-owb >>> >>> The packaging is a big jar that is not done yet (the APIs would of >>> course be separate JARs, but the goal is to have a big-OWB JAR tuned for >>> Tomcat with the rest). Eventually if it works well enough, I would move it >>> to https://github.com/apache/tomcat/tree/master/modules >>> >>> Note: I'm not a fan of the OWB configuration, it looks rather cryptic to >>> me (properties files spread across all the JARs, I guess that's pluggable - >>> even though it's not really needed here). I will look at that area for >>> Tomcat specific improvements (the main listener could be used for >>> configuration). >>> >>> Note 2: Apache CXF is quite the same first impression, when I download >>> it I find a "lib/WHICH_JARS" file, which kind of says it all. So after OWB, >>> it's possible there would be another tomcat-cxf module, which would be >>> packaging only (I hope/expect the integration, which uses CDI and Servlets, >>> will not need any real improvements). >>> >>> Comments ? >>> >>> Rémy >>> >>>