sbp commented on PR #456: URL: https://github.com/apache/tooling-trusted-releases/pull/456#issuecomment-3720805742
@developer-ravi-03 Thank you very much for the extensive comments! I was wondering a couple of things specifically: * Why have comments and whitespace been modified so heavily? * Why have you used a non-existent interface? What would be really helpful to us here is to understand where these problems with the commits are coming from. You could just revert the comments and the whitespace, and use the correct interface, but that's work that we could also do ourselves. What we're interested in is _how_ and _why_ we're receiving the sorts of PRs that we are. We're interested in why people are contributing and what methods they're using to produce their contributions. In short, I am very curious as to why you made the choices that you did in this PR. ATR is complex software with a security-focused stance. We welcome contributions, but they must be of a high quality. When quality is falling short, we're working to remediate the underlying causes so that we can improve all future contributions, rather than fixing just the individual problems. If you can help us at all to understand why and how you went wrong in this commit, that would be something we can replicate to other contributors. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
