sbp commented on PR #456:
URL:
https://github.com/apache/tooling-trusted-releases/pull/456#issuecomment-3732502553
Thank you for your engagement with this project. I appreciate the effort
you've put into communicating, but I cannot accept this PR or any further
contributions from you because this is not true:
> I’ve verified the changes by running the server on a supported Linux
environment (WSL) and confirmed that the audit log entry for automatic
committee updates behaves as expected.
And the latest commit is of a standard very far below what we expect for
contributions to this project:
```patch
@@ -391,6 +391,15 @@ async def _update_committees(
updated_count += 1
+ if added_committees or updated_committees:
+ cast("Any", log).audit(
+ action="committee_sync",
+ source="apache_whimsy",
+ details={
+ "added": sorted(added_committees),
+ "updated": sorted(updated_committees),
+ },
+ )
```
In future we will avoid such situations by raising the bar for entry for
contributions to ATR. We haven't yet concluded the details of this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
