developer-ravi-03 commented on PR #456: URL: https://github.com/apache/tooling-trusted-releases/pull/456#issuecomment-3722845339
Hi @sbp, thank you for taking the time to explain your concerns so clearly — I appreciate it. To answer your questions candidly: On the comment and whitespace changes: While implementing the audit logging, I added and adjusted comments to clarify the control flow and intent for my own understanding and for the self-review you requested. In hindsight, I agree that this resulted in a broader diff than necessary. I should have limited the changes strictly to the functional additions and kept explanatory context either in the PR description or review comments rather than modifying existing comments and formatting. On the non-existent interface: This was a mistake on my part. I inferred an interface/pattern based on surrounding code and my understanding of the flow, rather than confirming that it was an established abstraction in the project. That assumption was incorrect, and I understand why this is problematic in a security-sensitive codebase. More broadly, this PR was written manually by me, but I approached it with a focus on clarity and explanation rather than minimal surface-area change. I now see that this conflicts with the expectations for ATR, where tightly scoped, minimal diffs are preferred to support careful review and security guarantees. If it’s helpful, I’m very willing to: - Rework the PR to strictly minimize changes (reverting comment/whitespace edits) - Switch to the correct, existing interface - Or close this PR and resubmit a cleaner, more focused version following your guidance I appreciate the feedback and the emphasis on understanding why these issues arise — it’s valuable, and I’ll apply this learning to future contributions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
