Sorry for the delay in reviewing the bits. Comments:
KEYS file still missing. Did signature/checksum checks for binary, source and pip bundles. For the binary release, the assembly jar makes it a bit tough to validate all dependencies. Not completed this fully though. Would be good if other folks who are reviewing can help. For source release, there are a bunch of files without valid headers. Also some files like .example-image, etc are part of the release tarball when they should not be. ( used `find . -type f | xargs grep -L "Licensed to the Apache Software”` to find the ones in question). These should be fixed before the next release. The License/Notice file for the source bundle needs to be fixed. They contain entries for items that are not part of the source bundle. PKG-INFO for the pip package may need to be fixed. The license for it is not only ALv2 but a combination of all the other bits bundled into the assembly jar. License/Notice files: There are a bunch of copyright lines in the LICENSE file without any indication of why they are there. At the moment, it seems to indicate they are for all of the toree codebase. +0 for this release. I think that there has been enough work done on this initial release that it will be useful to get some more eyes from the larger Incubator group to provide more useful feedback. Please note that this vote does need atleast 3 PPMC +1s to pass. thanks — Hitesh > On Oct 27, 2016, at 7:34 AM, Gino Bustelo <g...@bustelos.com> wrote: > > Please vote to approve the release of the following candidate as > Apache Toree version 0.1.0. Pay special attention to the LICENSE and > NOTICE files since this is our first release. > > > The tag to be voted on is v0.1.0-rc3 > (5bef39490daeda69d98a1e4cf4096103e80be44d) > > *https://github.com/apache/incubator-toree/commit/5bef39490daeda69d98a1e4cf4096103e80be44d > <https://github.com/apache/incubator-toree/commit/5bef39490daeda69d98a1e4cf4096103e80be44d>* > > All distribution packages, including signatures, digests, etc. can be found > at: > > *https://dist.apache.org/repos/dist/dev/incubator/toree/0.1.0/rc3/ > <https://dist.apache.org/repos/dist/dev/incubator/toree/0.1.0/rc3/>* > > The vote is open for at least 72 hours and passes if a majority of at least > 3 +1 PMC votes are cast. > > [ ] +1 Release this package as Apache Toree 0.1.0 > [ ] -1 Do not release this package because ...
