gosonzhang commented on a change in pull request #125:
URL: https://github.com/apache/incubator-tubemq/pull/125#discussion_r435046493
##########
File path:
tubemq-client/src/main/java/org/apache/tubemq/client/producer/SimpleMessageProducer.java
##########
@@ -335,11 +336,13 @@ private void checkMessageAndStatus(final Message message)
throws TubeClientExcep
}
private byte[] encodePayload(final Message message) {
Review comment:
It would be better to put the message compression operation in the
Message class. It is open to the user and can avoid the situation where the
Message data has been compressed when it is sent and then compressed again.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
