gosonzhang commented on a change in pull request #125:
URL: https://github.com/apache/incubator-tubemq/pull/125#discussion_r435272490
##########
File path:
tubemq-core/src/main/java/org/apache/tubemq/corebase/utils/CompressionType.java
##########
@@ -0,0 +1,94 @@
+/**
Review comment:
Compression processing and compression enumeration need to be separated:
at present, there is no problem when there is only one compression method, but
subsequent compression methods are added, some methods need to be initialized,
and some require other processing, the enumeration class will become unstable,
and need to be adjusted frequently.
So enumerating compression methods and specific compression classification
will be better to solve this problem
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
