gosonzhang commented on a change in pull request #125:
URL: https://github.com/apache/incubator-tubemq/pull/125#discussion_r435276102
##########
File path:
tubemq-core/src/main/java/org/apache/tubemq/corebase/utils/DataConverterUtil.java
##########
@@ -233,8 +233,17 @@
payloadDataLen -= attrLen;
}
}
- final byte[] payload = new byte[payloadDataLen];
+ byte[] payload = new byte[payloadDataLen];
System.arraycopy(payloadData.array(), readPos, payload, 0,
payloadDataLen);
+ String compressionType = "";
Review comment:
The extraction of the compression type value needs to be performed by
calling the decoding function of the Message attribute. With the iteration of
the version, it may be changed later, and it is more appropriate to process it
by the method
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
