gosonzhang commented on a change in pull request #125:
URL: https://github.com/apache/incubator-tubemq/pull/125#discussion_r435284842
##########
File path:
tubemq-client/src/main/java/org/apache/tubemq/client/producer/SimpleMessageProducer.java
##########
@@ -321,7 +322,7 @@ private void checkMessageAndStatus(final Message message)
throws TubeClientExcep
builder.setTopicName(partition.getTopic());
builder.setPartitionId(partition.getPartitionId());
builder.setData(ByteString.copyFrom(encodePayload(message)));
- builder.setFlag(MessageFlagUtils.getFlag(message));
+ builder.setFlag(MessageFlagUtils.getFlag(message, true));
Review comment:
The function of payload data process is recommended to be placed on line
321, and the attribute need to be adjusted by the function,
and there is no need to add a mandatory flag setting, which will make the
maintenance personnel confused later.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
