Github user chtyim commented on a diff in the pull request:
    --- Diff: 
    @@ -149,6 +161,51 @@ public void setServices(List<String> services) {
         return services.get();
    +  /**
    +   * Get the map of the log level arguments of the twill application.
    +   *
    +   * @return the map of the log level arguments of the twill application
    +   */
    +  @Override
    +  public Map<String, Map<String, LogEntry.Level>> getLogLevels() {
    +    return logLevels;
    +  }
    +  /**
    +   * Save the log levels for the twill runnable.
    +   *
    +   * @param runnableName name of the runnable.
    +   * @param logLevels map of the log level arguments to be saved.
    +   */
    +  public void setLogLevels(String runnableName, Map<String, 
LogEntry.Level> logLevels) {
    +    Map<String, LogEntry.Level> newlogLevels = new 
    --- End diff --
    So I assume there will be non-concurrent calls to this method, right? 
Otherwise one will overwrite each other. Also, if that's the case, you don't 
need a `ConcurrentHashMap` as the value in the `logLevels` map, but rather an 
immutable map is sufficient.
    However, if there can be concurrent calls to this method, you'll need to 
merge the map, instead of replacing it.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

Reply via email to