Github user chtyim commented on a diff in the pull request:

    https://github.com/apache/twill/pull/14#discussion_r83108468
  
    --- Diff: 
twill-core/src/main/java/org/apache/twill/internal/TwillContainerLauncher.java 
---
    @@ -84,22 +84,29 @@ public TwillContainerLauncher(RuntimeSpecification 
runtimeSpec, ContainerInfo co
        * @param classPath The class path to load classes for the container.
        * @return instance of {@link TwillContainerController} to control the 
container run.
        */
    -  public TwillContainerController start(RunId runId, int instanceId, 
Class<?> mainClass, String classPath) {
    +  public TwillContainerController start(RunId runId, int instanceId, 
Class<?> mainClass, String classPath,
    +                                        Location logLevelLocation) {
    --- End diff --
    
    Is `logLevelLocation` nullable? I see you check that in line 104. If that's 
the case, annotate this parameter with `@Nullable`. Also, please update the 
javadoc accordingly.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to