Github user chtyim commented on a diff in the pull request:

    https://github.com/apache/twill/pull/14#discussion_r83108717
  
    --- Diff: 
twill-core/src/main/java/org/apache/twill/internal/json/TwillRunResourcesCodec.java
 ---
    @@ -41,7 +43,8 @@
       private static final String MEMORY_MB = "memoryMB";
       private static final String VIRTUAL_CORES = "virtualCores";
       private static final String DEBUG_PORT = "debugPort";
    -  private static final String LOG_LEVEL = "logLevel";
    +  private static final String LOG_LEVEL = "rootLogLevel";
    +  private static final String LOG_LEVEL_ARGUMENTS = "logLevels";
    --- End diff --
    
    Why not call it `LOG_LEVELS`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to