[ 
https://issues.apache.org/jira/browse/TWILL-138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15570257#comment-15570257
 ] 

ASF GitHub Bot commented on TWILL-138:
--------------------------------------

Github user chtyim commented on a diff in the pull request:

    https://github.com/apache/twill/pull/14#discussion_r83118218
  
    --- Diff: 
twill-yarn/src/main/java/org/apache/twill/internal/appmaster/RunningContainers.java
 ---
    @@ -132,16 +149,22 @@ void start(String runnableName, ContainerInfo 
containerInfo, TwillContainerLaunc
         try {
           int instanceId = getStartInstanceId(runnableName);
           RunId runId = getRunId(runnableName, instanceId);
    +      Map<String, LogEntry.Level> logLevelsRunnable = 
resourceReport.getLogLevels().containsKey(runnableName) ?
    +        resourceReport.getLogLevels().get(runnableName) : new 
HashMap<String, LogEntry.Level>();
    +      logLevel = logLevelsRunnable.containsKey(Logger.ROOT_LOGGER_NAME) ?
    --- End diff --
    
    Is `ROOT_LOGGER_NAME` a special logger name? If that's the case, we should 
be consistently using the map only. I see some other classes having both 
`rootLogLevel` and the map.


> Runtime change of Application runnable log level
> ------------------------------------------------
>
>                 Key: TWILL-138
>                 URL: https://issues.apache.org/jira/browse/TWILL-138
>             Project: Apache Twill
>          Issue Type: New Feature
>          Components: core
>            Reporter: Henry Saputra
>
> With TWILL-24 is supported for setting log level when starting the Twill 
> application, next enhancement is to able to send command to update the 
> aggregate log level for a particular runnable in a Twill application.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to