ASF GitHub Bot commented on TWILL-138:

Github user chtyim commented on a diff in the pull request:

    --- Diff: twill-api/src/main/java/org/apache/twill/api/TwillController.java 
    @@ -89,4 +90,34 @@
        * @return A {@link Future} that will be completed when the restart 
operation has been done.
       Future<String> restartInstances(String runnable, int instanceId, int... 
    +  /**
    +   * Set the root log level for Twill applications in all containers.
    +   *
    +   * @param logLevel The log level for the root logger to change.
    +   * @return A {@link Future} that will be completed when the set log 
level operation has been done. It will carry
    +   *         the {@link Map} of the log level as a result with ROOT as the 
logger name and the log level as value.
    +   */
    +  Future<Map<String, LogEntry.Level>> setLogLevel(LogEntry.Level logLevel);
    --- End diff --
    Also, for the `Future`, it seems like it's better just to carry 

> Runtime change of Application runnable log level
> ------------------------------------------------
>                 Key: TWILL-138
>                 URL: https://issues.apache.org/jira/browse/TWILL-138
>             Project: Apache Twill
>          Issue Type: New Feature
>          Components: core
>            Reporter: Henry Saputra
> With TWILL-24 is supported for setting log level when starting the Twill 
> application, next enhancement is to able to send command to update the 
> aggregate log level for a particular runnable in a Twill application.

This message was sent by Atlassian JIRA

Reply via email to