[ 
https://issues.apache.org/jira/browse/TWILL-138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15570259#comment-15570259
 ] 

ASF GitHub Bot commented on TWILL-138:
--------------------------------------

Github user chtyim commented on a diff in the pull request:

    https://github.com/apache/twill/pull/14#discussion_r83116780
  
    --- Diff: 
twill-yarn/src/main/java/org/apache/twill/internal/appmaster/ApplicationMasterService.java
 ---
    @@ -200,7 +201,9 @@ private RunningContainers 
initRunningContainers(ContainerId appMasterContainerId
           Integer.parseInt(System.getenv(EnvKeys.YARN_CONTAINER_MEMORY_MB)),
           appMasterHost, null, null);
         String appId = 
appMasterContainerId.getApplicationAttemptId().getApplicationId().toString();
    -    return new RunningContainers(appId, appMasterResources, zkClient);
    +    return new RunningContainers(appId, appMasterResources, zkClient,
    +                                 twillRuntimeSpec.getLogLevels(), 
applicationLocation,
    +                                 new 
ArrayList<>(twillSpec.getRunnables().keySet()));
    --- End diff --
    
    No need to copy since twill spec is immutable.


> Runtime change of Application runnable log level
> ------------------------------------------------
>
>                 Key: TWILL-138
>                 URL: https://issues.apache.org/jira/browse/TWILL-138
>             Project: Apache Twill
>          Issue Type: New Feature
>          Components: core
>            Reporter: Henry Saputra
>
> With TWILL-24 is supported for setting log level when starting the Twill 
> application, next enhancement is to able to send command to update the 
> aggregate log level for a particular runnable in a Twill application.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to