[ 
https://issues.apache.org/jira/browse/TWILL-138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15576946#comment-15576946
 ] 

ASF GitHub Bot commented on TWILL-138:
--------------------------------------

Github user chtyim commented on a diff in the pull request:

    https://github.com/apache/twill/pull/14#discussion_r83519511
  
    --- Diff: 
twill-api/src/main/java/org/apache/twill/internal/DefaultTwillRunResources.java 
---
    @@ -90,8 +103,18 @@ public Integer getDebugPort() {
       }
     
       @Override
    +  @Deprecated
       public Level getLogLevel() {
    -    return logLevel;
    +    return getRootLogLevel();
    +  }
    +
    +  @Override
    +  public Level getRootLogLevel() {
    +    return getLogLevels().get(Logger.ROOT_LOGGER_NAME);
    +  }
    +
    +  public Map<String, LogEntry.Level> getLogLevels() {
    --- End diff --
    
    Add `@Override`.


> Runtime change of Application runnable log level
> ------------------------------------------------
>
>                 Key: TWILL-138
>                 URL: https://issues.apache.org/jira/browse/TWILL-138
>             Project: Apache Twill
>          Issue Type: New Feature
>          Components: core
>            Reporter: Henry Saputra
>
> With TWILL-24 is supported for setting log level when starting the Twill 
> application, next enhancement is to able to send command to update the 
> aggregate log level for a particular runnable in a Twill application.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to