[ 
https://issues.apache.org/jira/browse/TWILL-138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15631276#comment-15631276
 ] 

ASF GitHub Bot commented on TWILL-138:
--------------------------------------

Github user anew commented on a diff in the pull request:

    https://github.com/apache/twill/pull/14#discussion_r86275989
  
    --- Diff: 
twill-core/src/main/java/org/apache/twill/internal/json/ResourceReportAdapter.java
 ---
    @@ -59,4 +72,61 @@ public ResourceReport fromJson(String json) {
       public ResourceReport fromJson(Reader reader) {
         return gson.fromJson(reader, ResourceReport.class);
       }
    +
    +  /**
    +   * A type adapter for serializing {@code Collection<TwillRunResources>} 
correctly
    +   */
    +  private static final class ResourceReportTypeAdapterFactory implements 
TypeAdapterFactory {
    +
    +    @SuppressWarnings("unchecked")
    +    @Override
    +    public <T> TypeAdapter<T> create(Gson gson, TypeToken<T> type) {
    +      if (!Collection.class.isAssignableFrom(type.getRawType())) {
    +        return null;
    +      }
    +
    +      if (!(type.getType() instanceof ParameterizedType)) {
    +        return null;
    --- End diff --
    
    ditto


> Runtime change of Application runnable log level
> ------------------------------------------------
>
>                 Key: TWILL-138
>                 URL: https://issues.apache.org/jira/browse/TWILL-138
>             Project: Apache Twill
>          Issue Type: New Feature
>          Components: core
>            Reporter: Henry Saputra
>
> With TWILL-24 is supported for setting log level when starting the Twill 
> application, next enhancement is to able to send command to update the 
> aggregate log level for a particular runnable in a Twill application.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to