[ 
https://issues.apache.org/jira/browse/TWILL-138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15576951#comment-15576951
 ] 

ASF GitHub Bot commented on TWILL-138:
--------------------------------------

Github user chtyim commented on a diff in the pull request:

    https://github.com/apache/twill/pull/14#discussion_r83519663
  
    --- Diff: 
twill-core/src/main/java/org/apache/twill/internal/DefaultResourceReport.java 
---
    @@ -39,25 +44,33 @@
       private final TwillRunResources appMasterResources;
       private final String applicationId;
       private final AtomicReference<List<String>> services;
    +  private final Map<String, Map<String, LogEntry.Level>> logLevels;
     
       public DefaultResourceReport(String applicationId, TwillRunResources 
masterResources) {
    -    this(applicationId, masterResources, ImmutableMap.<String, 
Collection<TwillRunResources>>of());
    -  }
    -
    -  public DefaultResourceReport(String applicationId, TwillRunResources 
masterResources,
    -                               Map<String, Collection<TwillRunResources>> 
resources) {
    -    this(applicationId, masterResources, resources, 
ImmutableList.<String>of());
    +    this(applicationId, masterResources, Collections.<String, 
Collection<TwillRunResources>>emptyMap(),
    +         Collections.<String>emptyList());
       }
     
       public DefaultResourceReport(String applicationId, TwillRunResources 
masterResources,
                                    Map<String, Collection<TwillRunResources>> 
resources, List<String> services) {
         this.applicationId = applicationId;
         this.appMasterResources = masterResources;
    -    this.usedResources = HashMultimap.create();
    +    this.usedResources = 
Multimaps.synchronizedSetMultimap(HashMultimap.<String, 
TwillRunResources>create());
         for (Map.Entry<String, Collection<TwillRunResources>> entry : 
resources.entrySet()) {
           this.usedResources.putAll(entry.getKey(), entry.getValue());
         }
         this.services = new AtomicReference<>(services);
    +    this.logLevels = new ConcurrentHashMap<>();
    +  }
    +
    +  public synchronized void setRunnableLogLevels(String runnableName, 
Map<String, LogEntry.Level> runnableLogLevels) {
    --- End diff --
    
    Also, maybe good to just return if the `runnableLogLevels` map is empty.


> Runtime change of Application runnable log level
> ------------------------------------------------
>
>                 Key: TWILL-138
>                 URL: https://issues.apache.org/jira/browse/TWILL-138
>             Project: Apache Twill
>          Issue Type: New Feature
>          Components: core
>            Reporter: Henry Saputra
>
> With TWILL-24 is supported for setting log level when starting the Twill 
> application, next enhancement is to able to send command to update the 
> aggregate log level for a particular runnable in a Twill application.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to