Github user chtyim commented on a diff in the pull request:

    https://github.com/apache/twill/pull/58#discussion_r132040093
  
    --- Diff: 
twill-yarn/src/main/java/org/apache/twill/internal/appmaster/RunningContainers.java
 ---
    @@ -267,6 +280,14 @@ void stopByIdAndWait(String runnableName, int 
instanceId) {
     
             resourceReport.removeRunnableResources(runnableName, containerId);
             containerChange.signalAll();
    +        if (eventHandler != null) {
    +          Integer exitStatus = containerExitStatus.get(containerId);
    +          if (exitStatus == null) {
    --- End diff --
    
    So this is for handling the case when `handleCompleted` was not called 
(e.g. the runnable container is not stopping after receiving the "stop" 
command), right? If that's the case, isn't that the exit status is always not 
there?
    
    Also, do we need to do the similar logic to call event handler in the 
`stopAll` method?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to