Github user chtyim commented on a diff in the pull request:

    https://github.com/apache/twill/pull/58#discussion_r132295847
  
    --- Diff: 
twill-yarn/src/main/java/org/apache/twill/internal/appmaster/ApplicationMasterService.java
 ---
    @@ -181,7 +189,6 @@ public Reader getInput() throws IOException {
       }
     
       @SuppressWarnings("unchecked")
    -  @Nullable
       private EventHandler createEventHandler(TwillSpecification twillSpec) 
throws ClassNotFoundException {
         // Should be able to load by this class ClassLoader, as they packaged 
in the same jar.
         EventHandlerSpecification handlerSpec = twillSpec.getEventHandler();
    --- End diff --
    
    if `handlerSpec` is `null`, you still want to return a no-op handler, right?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to