Github user chtyim commented on a diff in the pull request:

    https://github.com/apache/twill/pull/58#discussion_r132037568
  
    --- Diff: 
twill-yarn/src/main/java/org/apache/twill/internal/appmaster/ApplicationMasterService.java
 ---
    @@ -221,7 +229,8 @@ protected void doStart() throws Exception {
     
         // initialize the event handler, if it fails, it will fail the 
application.
         if (eventHandler != null) {
    -      eventHandler.initialize(new 
BasicEventHandlerContext(twillSpec.getEventHandler()));
    +      eventHandler.initialize(new 
BasicEventHandlerContext(twillRuntimeSpec, twillSpec.getEventHandler()));
    --- End diff --
    
    The `twillRuntimeSpec` already contains `twillSpec`. Seems unnecessary to 
pass in `twillSpec.getEventHandler()` as a separate parameter.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to