Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/58#discussion_r132038164
--- Diff:
twill-yarn/src/main/java/org/apache/twill/internal/appmaster/RunningContainers.java
---
@@ -173,6 +183,9 @@ void start(String runnableName, ContainerInfo
containerInfo, TwillContainerLaunc
startSequence.addLast(runnableName);
}
containerChange.signalAll();
+ if (eventHandler != null) {
+ eventHandler.containerLaunched(runnableName, instanceId,
containerInfo.getId());
--- End diff --
How do we handle exception raised from event handler methods?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
