Github user chtyim commented on a diff in the pull request:

    https://github.com/apache/twill/pull/58#discussion_r132297954
  
    --- Diff: 
twill-yarn/src/main/java/org/apache/twill/internal/appmaster/RunningContainers.java
 ---
    @@ -401,6 +409,24 @@ void stopAll() {
         // When we acquire this lock, all stopped runnables should have been 
cleaned up by handleCompleted() method
         containerLock.lock();
         try {
    +      for (Map.Entry<String, Map<String, TwillContainerController>> entry 
: containers.rowMap().entrySet()) {
    +        String runnableName = entry.getKey();
    +        Collection<ContainerInfo> containerInfos = 
containerStats.get(runnableName);
    +        for (Map.Entry<String, TwillContainerController> 
containerControllerEntry : entry.getValue().entrySet()) {
    +          boolean containerExist = false;
    +          for (ContainerInfo containerInfo : containerInfos) {
    +            if 
(containerInfo.getId().equals(containerControllerEntry.getKey())) {
    +              containerExist = true;
    +              break;
    +            }
    +          }
    +          // Only call eventHandler.containerStopped if container is not 
removed by handleCompleted
    +          if (containerExist) {
    +            eventHandler.containerStopped(runnableName, 
containerControllerEntry.getValue().getInstanceId(),
    --- End diff --
    
    you can move this inside the `for` loop and no need to use `containerExist`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to