Richard Eckart de Castilho commented on UIMA-1524:

2) can we include typePriorities() and typePriorities(boolean)? I think in some 
cases it may be more convenient to pass a boolean then to change to code flow 
to exclude this call.

4) I'm for special casing that. We could ask people on the list, but I never 
had anybody complaining about this behavior. A builder like "includeContext()" 
or "includeOrigin()" could be added to disable this special case.

5) how about using skip(int) to handle offsets?

6) not entirely sure what you are asking. uimaFIT definitely has the limit arg, 
but not the skip/offset arg. Not sure if we need it, but also wouldn't object 
having it. [~pkluegl] do you need something like this in Ruta?

7) didn't understand that. If I call reverse(), then I would expect that I 
continue to move the cursor into the opposite direction afterwards. I guess 
what you are saying is that reverse() changes the order of the list but not the 
direction in which the cursor moves. Ok, makes sense... so we should then have 
a preceeding verb.

8) single() is meant to throw an exception in the case where not exactly one 
instance is available. UIMA-3234 suggest that two different exceptions should 
be thrown depending on whether the instance is missing or whether there is more 
than one instance. A get method with a positional argument does not cover these 
conditions. single() is meant to be used with singleton FSes such as 
DocumentMetaData (yes, I know that there is a dedicated getter for this in the 
CAS, but it requires typecasting if a user has created a custom subclass of it 
- also there may be additional singleton annotations in the CAS).

> JFSIndexRepository should be enhanced with new generic methods
> --------------------------------------------------------------
>                 Key: UIMA-1524
>                 URL: https://issues.apache.org/jira/browse/UIMA-1524
>             Project: UIMA
>          Issue Type: Improvement
>          Components: Core Java Framework
>    Affects Versions: 2.3
>            Reporter: Joern Kottmann
> Existing methods should be overloaded with an additional Class argument to 
> specify the exact return type. This changes make down casting of returned 
> objects unnecessary. 

This message was sent by Atlassian JIRA

Reply via email to