sergehuber commented on a change in pull request #131: Add the ability to
update event by item id
URL: https://github.com/apache/unomi/pull/131#discussion_r386430982
##########
File path: wab/src/main/java/org/apache/unomi/web/ServletCommon.java
##########
@@ -73,6 +73,9 @@ public static Changes handleEvents(List<Event> events,
Session session, Profile
logger.warn("Event is not allowed : {}",
event.getEventType());
continue;
}
+ if (event.getItemId() != null) {
Review comment:
I think it would be best to check if the thirdPartyId != null in that
condition so it would become:
if (thirdPartyId != null && event.getItemId() != null) {
This way the itemId would only be accepted if a configured server Id is
doing the request and it provides the Unomi Key.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
