RonBarabash commented on a change in pull request #131: Add the ability to
update event by item id
URL: https://github.com/apache/unomi/pull/131#discussion_r386956917
##########
File path: wab/src/main/java/org/apache/unomi/web/ServletCommon.java
##########
@@ -73,6 +73,9 @@ public static Changes handleEvents(List<Event> events,
Session session, Profile
logger.warn("Event is not allowed : {}",
event.getEventType());
continue;
}
+ if (event.getItemId() != null) {
Review comment:
Im sorry @sergehuber but i dont understand why creating a new item might
solve this.
Its also very unscalable to create a new item per event type we want to add
to the system.
Do u think maybe we should talk in over the phone for u to get a better
understanding on why we need this feature?
And again, Why not add a generic behaviour and functionality that should
work for some of the use cases with Unomi? this PR does not suggesting breaking
changes or a change in concept. having the ability to update events to me seems
trivial, some of the users of Unomi can enable it, and some dont, even more so
when we guarded this using the 3rd party id check...
Creating Item Types for each Event Type for me is abusing the system to do
something that it doesn't suppose to do.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
