sergehuber commented on a change in pull request #131: Add the ability to
update event by item id
URL: https://github.com/apache/unomi/pull/131#discussion_r392120875
##########
File path: wab/src/main/java/org/apache/unomi/web/ServletCommon.java
##########
@@ -73,6 +73,9 @@ public static Changes handleEvents(List<Event> events,
Session session, Profile
logger.warn("Event is not allowed : {}",
event.getEventType());
continue;
}
+ if (event.getItemId() != null) {
Review comment:
Following our meeting it was decided to:
- Move the event update logic into a management API (tracked using this
ticket :
https://issues.apache.org/jira/projects/UNOMI/issues/UNOMI-288?filter=allopenissues)
- Update the event collector to reject an event with an existing ID. This
also means that the logic inside the rule service probably isn't needed anymore?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
