sergehuber commented on a change in pull request #131: Add the ability to
update event by item id
URL: https://github.com/apache/unomi/pull/131#discussion_r386846792
##########
File path: wab/src/main/java/org/apache/unomi/web/ServletCommon.java
##########
@@ -73,6 +73,9 @@ public static Changes handleEvents(List<Event> events,
Session session, Profile
logger.warn("Event is not allowed : {}",
event.getEventType());
continue;
}
+ if (event.getItemId() != null) {
Review comment:
Hi Ron, thanks for adding the suggestion, this is much better. Now all that
is left is to check for migration issues but I have to test the branch to check
for that.
Actually now that you mention it you didn't give me any feedback on this
part of my suggestion: "Another "more Unomi compliant" would be to, instead of
replying the SAME events, you would send a new event of type "updateEvent" (or
any name you choose), that would have an associated rule that would modify
existing events. The disadvantage of this method is that events might grow
quickly every type you update the events, but at least you would have full
traceability of what happened overtime."
Finally, I'd love to have more context on what you are using this for,
because I wonder for example how often you see these model changes and if you
could give me more examples of real cases? I'm just curious here because I
haven't encountered this much for the moment.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
