Any thoughts on the above idea or did we fix it in a different way? On Sat, Sep 23, 2017 at 9:46 AM, Johann Nallathamby <[email protected]> wrote:
> See if this idea would work? > > We currently set a threadlocal variable inside the SCIM endpoint > component, to identify the SCIM service provider inside some of our > implementations. Can we improve this variable value to also identify the > SCIM version? This way the relevant listeners will check for the correct > version and only execute. > > For management console operations we won't have a threadlocal set. In that > case one of the listeners (ideally SCIM2) will execute and do the necessary > changes to the user store, so that thereafter even if we do calls using > SCIM 1.1. it should work without a problem. > > This way we are not coupling the listeners, each version works > independently, and management console will depend on latest version. Even > if tomorrow SCIM 3.0 comes out we don't need to change existing code :) > > Anyone see any issue with this approach? Am I missing anything? > > Regards, > Johann. > > On Mon, Sep 18, 2017 at 11:04 AM, Pulasthi Mahawithana <[email protected] > > wrote: > >> Hi Gayan, >> >> On Mon, Sep 18, 2017 at 10:43 AM, Gayan Gunawardana <[email protected]> >> wrote: >> >>> >>> >>> On Mon, Sep 18, 2017 at 10:19 AM, Prabath Siriwardena <[email protected]> >>> wrote: >>> >>>> >>>> >>>> On Sun, Sep 17, 2017 at 9:42 PM, Gayan Gunawardana <[email protected]> >>>> wrote: >>>> >>>>> >>>>> >>>>> On Mon, Sep 18, 2017 at 8:29 AM, Darshana Gunawardana < >>>>> [email protected]> wrote: >>>>> >>>>>> Hi Prabath, >>>>>> >>>>>> We do have two endpoints for SCIM 1.1 & SCIM 2. But there are some >>>>>> listeners we need to enable in order to populated relevant metadata such >>>>>> as >>>>>> ID, Created\Modified dates against the correct URI specified by the each >>>>>> specification. >>>>>> >>>>>> Given that, different clients may use different protocol of they >>>>>> already support, we should have ability to have both protocols working >>>>>> simultaneously. >>>>>> >>>>> According to this even single client can use SCIM 1.1 and 2.0 >>>>> simultaneously right ? >>>>> Yes so ideally it should work but in practice it will bring some >>>>> complexities. We have to test use-cases like creating user with SCIM 1.1 >>>>> and updating with SCIM 2.0. >>>>> IMO we should support only one protocol at a time but not both. >>>>> >>>> >>>> Can we please identify those complexities...? >>>> >>>> We cannot terminate support for SCIM 1.1 - both have to co-exist for >>>> few releases till we deprecate SCIM 1.1. If both cannot co-exist then we >>>> need to review our design... >>>> >>> What I am suggesting is not to terminate support for SCIM 1.1 but at a >>> time enable only. >>> Enable SCIM 1.1 as default option. If client applications work with SCIM >>> 1.1 they can continue. If client applications want to work with SCIM 2.0 we >>> should be able to enable SCIM 2.0 by disabling SCIM 1.1 from >>> configurations. >>> >> >> What I initially suggested was the other way around. That is having SCIM >> 2 as default and make SCIM 1.1 to enable with a config change. The reason >> is, for any new users, they can use the newer standard OOTB without any >> config changes. And for existing users who are using SCIM 1.1 clients will >> anyway need to migrate to 5.4.0. During the migration, we keep the existing >> configuration. So for them SCIM 1.1 will be enabled by default after the >> migration process (They may switch later if needed). >> >> Anyway, as Darshana mentioned, We'll look for the possibility of having >> both of them enabled at once. >> >>> >>>> Thanks & regards, >>>> -Prabath >>>> >>>> >>>> >>>>> >>>>>> Created: https://wso2.org/jira/browse/IDENTITY-6458 to track this. >>>>>> >>>>>> Thanks, >>>>>> >>>>>> On Mon, Sep 18, 2017 at 8:11 AM, Darshana Gunawardana < >>>>>> [email protected]> wrote: >>>>>> >>>>>>> Hi Gayan, >>>>>>> >>>>>>> Due to the limitation we have in the user core level, we don't >>>>>>> support complex filtering, pagination, sorting. Refer [1] & [2]. >>>>>>> >>>>>>> [1] https://github.com/wso2-extensions/identity-inbound-prov >>>>>>> isioning-scim2/blob/v1.0.5/components/org.wso2.carbon.identi >>>>>>> ty.scim2.common/src/main/java/org/wso2/carbon/identity/scim2 >>>>>>> /common/impl/SCIMUserManager.java#L834 >>>>>>> [2] https://github.com/wso2-extensions/identity-inbound-prov >>>>>>> isioning-scim2/blob/v1.0.5/components/org.wso2.carbon.identi >>>>>>> ty.scim2.common/src/main/java/org/wso2/carbon/identity/scim2 >>>>>>> /common/impl/SCIMUserManager.java#L793 >>>>>>> >>>>>>> Thanks, >>>>>>> >>>>>>> On Mon, Sep 18, 2017 at 7:50 AM, Gayan Gunawardana <[email protected]> >>>>>>> wrote: >>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> On Mon, Sep 11, 2017 at 9:14 PM, Vindula Jayawardana < >>>>>>>> [email protected]> wrote: >>>>>>>> >>>>>>>>> Hi, >>>>>>>>> >>>>>>>>> +1 for this as the global adoption of SCIM 2.0 is right on the >>>>>>>>> track as Ishara has mentioned. >>>>>>>>> >>>>>>>> @Vindula >>>>>>>> Do we support pagination, complex filters and bulk operation to >>>>>>>> resolve cyclic dependencies. As I know you have implemented these >>>>>>>> features >>>>>>>> but there are some limitations because of C4 user core component. I am >>>>>>>> not >>>>>>>> sure about the meaning of word "default" but if we are promoting SCIM >>>>>>>> 2.0, >>>>>>>> have to inform what is the real value getting out of it. >>>>>>>> >>>>>>>>> >>>>>>>>> Thanks >>>>>>>>> >>>>>>>>> *Vindula Jayawardana* >>>>>>>>> Computer Science and Engineering Dept. >>>>>>>>> University of Moratuwa >>>>>>>>> mobile : +713462554 >>>>>>>>> Email : [email protected] >>>>>>>>> >>>>>>>>> <https://www.facebook.com/vindula.jayawardana> >>>>>>>>> <http://lk.linkedin.com/pub/vindula-jayawardana/a7/315/53b> >>>>>>>>> <https://plus.google.com/u/0/+VindulaJayawardana/posts> >>>>>>>>> <https://twitter.com/vindulajay> >>>>>>>>> >>>>>>>>> *“Respect is how to treat everyone, not just those you want to >>>>>>>>> impress. "* >>>>>>>>> >>>>>>>>> >>>>>>>>> *-Richard Branson-* >>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>> On 11 September 2017 at 19:10, Darshana Gunawardana < >>>>>>>>> [email protected]> wrote: >>>>>>>>> >>>>>>>>>> One aspect is that we don't have a SCIM 2.0 outbound provisioning >>>>>>>>>> connector available. So IS to IS provisioning will not be smooth >>>>>>>>>> until we >>>>>>>>>> get the outbound provisioning connector ready. >>>>>>>>>> >>>>>>>>>> On Mon, Sep 11, 2017 at 5:34 PM, Pulasthi Mahawithana < >>>>>>>>>> [email protected]> wrote: >>>>>>>>>> >>>>>>>>>>> Hi, >>>>>>>>>>> >>>>>>>>>>> Shall we make $subject instead of SCIM 1.1? Any known issues on >>>>>>>>>>> having it as default? Users who are migrating from older versions >>>>>>>>>>> will >>>>>>>>>>> still have SCIM 1.1 configs and won't be affected as they would >>>>>>>>>>> keep the >>>>>>>>>>> old configs. >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> -- >>>>>>>>>>> *Pulasthi Mahawithana* >>>>>>>>>>> Senior Software Engineer >>>>>>>>>>> WSO2 Inc., http://wso2.com/ >>>>>>>>>>> Mobile: +94-71-5179022 <+94%2071%20517%209022> >>>>>>>>>>> Blog: https://medium.com/@pulasthi7/ >>>>>>>>>>> >>>>>>>>>>> <https://wso2.com/signature> >>>>>>>>>>> >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> -- >>>>>>>>>> Regards, >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> *Darshana Gunawardana*Technical Lead >>>>>>>>>> WSO2 Inc.; http://wso2.com >>>>>>>>>> >>>>>>>>>> *E-mail: [email protected] <[email protected]>* >>>>>>>>>> *Mobile: +94718566859 <+94%2071%20856%206859>*Lean . Enterprise >>>>>>>>>> . Middleware >>>>>>>>>> >>>>>>>>>> _______________________________________________ >>>>>>>>>> Dev mailing list >>>>>>>>>> [email protected] >>>>>>>>>> http://wso2.org/cgi-bin/mailman/listinfo/dev >>>>>>>>>> >>>>>>>>>> >>>>>>>>> >>>>>>>>> _______________________________________________ >>>>>>>>> Dev mailing list >>>>>>>>> [email protected] >>>>>>>>> http://wso2.org/cgi-bin/mailman/listinfo/dev >>>>>>>>> >>>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> -- >>>>>>>> Gayan Gunawardana >>>>>>>> Senior Software Engineer; WSO2 Inc.; http://wso2.com/ >>>>>>>> Email: [email protected] >>>>>>>> Mobile: +94 (71) 8020933 >>>>>>>> >>>>>>> >>>>>>> >>>>>>> >>>>>>> -- >>>>>>> Regards, >>>>>>> >>>>>>> >>>>>>> *Darshana Gunawardana*Technical Lead >>>>>>> WSO2 Inc.; http://wso2.com >>>>>>> >>>>>>> *E-mail: [email protected] <[email protected]>* >>>>>>> *Mobile: +94718566859 <+94%2071%20856%206859>*Lean . Enterprise . >>>>>>> Middleware >>>>>>> >>>>>> >>>>>> >>>>>> >>>>>> -- >>>>>> Regards, >>>>>> >>>>>> >>>>>> *Darshana Gunawardana*Technical Lead >>>>>> WSO2 Inc.; http://wso2.com >>>>>> >>>>>> *E-mail: [email protected] <[email protected]>* >>>>>> *Mobile: +94718566859 <+94%2071%20856%206859>*Lean . Enterprise . >>>>>> Middleware >>>>>> >>>>> >>>>> >>>>> >>>>> -- >>>>> Gayan Gunawardana >>>>> Senior Software Engineer; WSO2 Inc.; http://wso2.com/ >>>>> Email: [email protected] >>>>> Mobile: +94 (71) 8020933 >>>>> >>>> >>>> >>>> >>>> -- >>>> Thanks & Regards, >>>> Prabath >>>> >>>> Twitter : @prabath >>>> LinkedIn : http://www.linkedin.com/in/prabathsiriwardena >>>> >>>> Mobile : +1 650 625 7950 <%28650%29%20625-7950> >>>> >>>> http://facilelogin.com >>>> >>> >>> >>> >>> -- >>> Gayan Gunawardana >>> Senior Software Engineer; WSO2 Inc.; http://wso2.com/ >>> Email: [email protected] >>> Mobile: +94 (71) 8020933 >>> >>> _______________________________________________ >>> Dev mailing list >>> [email protected] >>> http://wso2.org/cgi-bin/mailman/listinfo/dev >>> >>> >> >> >> -- >> *Pulasthi Mahawithana* >> Senior Software Engineer >> WSO2 Inc., http://wso2.com/ >> Mobile: +94-71-5179022 <+94%2071%20517%209022> >> Blog: https://medium.com/@pulasthi7/ >> >> <https://wso2.com/signature> >> >> _______________________________________________ >> Dev mailing list >> [email protected] >> http://wso2.org/cgi-bin/mailman/listinfo/dev >> >> > > > -- > Thanks & Regards, > > *Johann Dilantha Nallathamby* > Senior Lead Solutions Engineer > WSO2, Inc. > lean.enterprise.middleware > > Mobile - *+94777776950* > Blog - *http://nallaa.wordpress.com <http://nallaa.wordpress.com>* > -- Thanks & Regards, *Johann Dilantha Nallathamby* Senior Lead Solutions Engineer WSO2, Inc. lean.enterprise.middleware Mobile - *+94777776950* Blog - *http://nallaa.wordpress.com <http://nallaa.wordpress.com>*
_______________________________________________ Dev mailing list [email protected] http://wso2.org/cgi-bin/mailman/listinfo/dev
