I'm ok with either approach especially since you are doing all the
heavy lifting.
But since we are both already fairly fresh on this project, it might be
best to improve whatever we can now.
My 2c,
Gary
On Tue, Jan 17, 2023, 09:19 Mukul Gandhi <muk...@apache.org> wrote:
> Hi Gary & all,
> I've analyzed, the below two issues (that seems to raise, real
> doubts about the integrity of XalanJ 2.7.3 release tests) mentioned by
> you for the XalanJ 2.7.3 RC9, and my findings (this time more
> completely, and confirmed from my side) are mentioned inline below.
>
> On Mon, Jan 9, 2023 at 9:19 PM Gary D. Gregory <ggreg...@apache.org>
> wrote:
>
> > Also, out of "build smoketest", I see:
> >
> > scan:
> > [java] ResultScanner error on: results-api
> > [java] java.io.FileNotFoundException: ResultScanner: resultDir
> results-api does not exist!
> > [java] at
> org.apache.qetest.xsl.ResultScanner.scanResults(ResultScanner.java:67)
> > [java] at
> org.apache.qetest.xsl.ResultScanner.main(ResultScanner.java:326)
> > [echo] About to execute XalanJ2 extensions tests...
> >
> > Is that something to worry about?
>
> When we run the XalanJ tests build command "build smoketest", that
> runs the ant target smoketest-execute as part of itself. The ant
> target smoketest-execute, runs following ant targets in sequence as
> part of itself,
>
> "conf", "accept", "api" and "extensions".
>
> The "api" ant target seems to have, few issues when run as part of ant
> target smoketest-execute (and that's why, we get errors like above
> that you've cited).
>
> To debug this, I've made few changes locally to XalanJ tests build
> configuration, and when I run XalanJ's ant target "api" separately, it
> runs fine and produces tests results success for the XalanJ ant "api"
> target.
>
> My local changes, to improve XalanJ ant target "api" runs following
> sets of tests (I've selected the following sets of tests. These are
> large in numbers, and ensure sufficient quality of the ant target
> "api"),
>
> # Various tests, that run for ant build.xml's "api" target
>
> qetest.dtm.tests=TestDTM;TestDTMIter;TestDTMTrav;TimeDTMIterDeep;TimeDTMTravDeep
> qetest.rwapi.tests=XPathASTTestlet
> qetest.trax.dom.tests=DOMResultAPITest;DOMSourceAPITest
>
> qetest.trax.sax.tests=SAXResultAPITest;SAXSourceAPITest;SAXTransformerFactoryAPITest;TemplatesHandlerAPITest;TransformerHandlerAPITest;TransformerHandlerTest
> qetest.trax.stream.tests=StreamResultAPITest;StreamSourceAPITest
>
> qetest.trax.tests=EmbeddedStylesheetTest;ErrorListenerAPITest;ErrorListenerTest;Minitest;OutputPropertiesTest;ParameterTest;SystemIdImpInclTest;SystemIdTest;TemplatesAPITest;TransformerAPITest;TransformerFactoryAPITest;URIResolverTest
>
> qetest.xalanj2.tests=DTMDumpTest;FactoryFeatureTest;OutputSettingsTest;PrefixResolverAPITest;ProgrammaticDOMTest;SerializedStylesheetTest;SmoketestOuttakes;SystemIDResolverAPITest;TestXPathAPI;TraceListenerTest;TransformStateAPITest;TransformStateTest
>
> >
> > During "build conf.xsltc", I see a couple of:
> >
> > [xalantest] ERROR StylesheetTestlet{trax} attribset15.xsl threw:
> javax.xml.transform.TransformerConfigurationException: Could not compile
> stylesheet
> >
> > But again, I do not know if this is normal or not. Are we testing actual
> compiling errors?
>
> My findings shows that, with XalanJ tests ant target conf.xsltc, the
> error "javax.xml.transform.TransformerConfigurationException: Could
> not compile stylesheet" is due to only 2-3 XSLT tests stylesheets, and
> all these 2-3 XSLT stylesheets have legitimate compilation errors.
> i.e, the error messages "Could not compile stylesheet" indicates the
> related tests success. I've fixed this issue as well on my local.
>
> I'd suggest one of following two approaches going forward, for these
> issues,
>
> 1) We fix the XalanJ tests build to solve these issues, and make a new
> XalanJ 2.7.3 RC. If I've to do this, it'll take me few more days to
> complete this task.
>
> 2) We can ignore these issues for now (and we can make improvements,
> to XalanJ tests build after XalanJ 2.7.3 release), and try to approve
> the XalanJ 2.7.3 RC9.
>
> Please advise as appropriate.
>
>
> --
> Regards,
> Mukul Gandhi
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscr...@xalan.apache.org
> For additional commands, e-mail: dev-h...@xalan.apache.org
>
>
