jkesselm commented on PR #1:
URL: https://github.com/apache/xalan-test/pull/1#issuecomment-1546700059
Squash, by all means.
Valid point re tooling configs and code style.
--
/_ Joe Kesselman (he/him/his)
-/ _) My Alexa skill for New Music/New Sounds fans:
/ https://www.amazon.com/dp/B09WJ3H657/
() Plaintext Ribbon Campaign
/\ Stamp out HTML mail!
________________________________
From: Gary Gregory ***@***.***>
Sent: Saturday, May 13, 2023 11:30:43 AM
To: apache/xalan-test ***@***.***>
Cc: Joe Kesselman ***@***.***>; Mention ***@***.***>
Subject: Re: [apache/xalan-test] Move tests/2.7.3 into main test driver
framework, document bugzilla test status (PR #1)
@garydgregory commented on this pull request.
@jkesselm<https://github.com/jkesselm> and all:
Do you care about the commit history or can I squash & commit? I generally
squash PRs assuming that the commits are WIP (unless I hear otherwise).
I would prefer we NOT store Eclipse, IntelliJ, and assorted editor
configuration files. It is too painful to sync; instead we should, IMO: Migrate
to Maven and enforce style with the Maven Checkstyle plugin or use the Spotless
plugin in addition to PMD and SpotBugs.
—
Reply to this email directly, view it on
GitHub<https://github.com/apache/xalan-test/pull/1#pullrequestreview-1425426992>,
or
unsubscribe<https://github.com/notifications/unsubscribe-auth/A7OJ6WZTEOSNHAUFJNK7KODXF6SKHANCNFSM6AAAAAAXNHL2SY>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@xalan.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@xalan.apache.org
For additional commands, e-mail: dev-h...@xalan.apache.org
