jkesselm commented on PR #1:
URL: https://github.com/apache/xalan-test/pull/1#issuecomment-1542682359
We (meaning the IBM group) used to have a shared Eclipse profile that
included some code style settings, which helped ensure some consistency.
Apparently that didn't get checked into the project, probably because we were
using a different source manager (subversion?) which didn't encourage that.
We could derive the existing conventions from the code, assuming that the
majority of the codebase hasn't changed much since then. (Which, alas, is
probably true.) Or we can try to get consensus and push it into that form,
confirming that the change results in the same byte codes (modulo debugging
line numbers) as a rigorous proof that the change has no side effects.
This is near the bottom of my own priority list; I'm a firm believer that
code style consistency is a tool toward code readability and that clarity of
intent trumps formalism. I'm certainly not going to deliberately break it, but
I'm not very motivated to invest my own time on changing what already exists.
(I'm also a believer that a competent programmer should be able to both read
and write most of the existing style conventions, though I recognize that
Apache code is partly pedagogical. And I only say "most" because I've been
exposed to some hideous examples, like the guy who thought semicolons belonged
at the start of C statements rather than the end.)
--
/_ Joe Kesselman (he/him/his)
-/ _) My Alexa skill for New Music/New Sounds fans:
/ https://www.amazon.com/dp/B09WJ3H657/
() Plaintext Ribbon Campaign
/\ Stamp out HTML mail!
________________________________
From: Elliotte Rusty Harold ***@***.***>
Sent: Wednesday, May 10, 2023 2:29:53 PM
To: apache/xalan-test ***@***.***>
Cc: Joe Kesselman ***@***.***>; Author ***@***.***>
Subject: Re: [apache/xalan-test] Move tests/2.7.3 into main test driver
framework, document bugzilla test status (PR #1)
I think we fundamentally agree. I'm fine with four space indents on
continuation lines, or whatever project conventions folks like, provided it's
written down somewhere. Are there code conventions for this project? I looked
but couldn't find any. Ideally we would also have autoformatters on submit (not
format checks but actual formatters running on the source repo) that make
formatting nits moot. Absent explicit style guidelines, formatting tends to
vary idiosyncratcially from file to file and line to line, and there's a lot of
confusing churn as different editors autoformat to different conventions.
—
Reply to this email directly, view it on
GitHub<https://github.com/apache/xalan-test/pull/1#issuecomment-1542631630>, or
unsubscribe<https://github.com/notifications/unsubscribe-auth/A7OJ6W4C6VUGCFHX3J6F5VDXFPNCDANCNFSM6AAAAAAXNHL2SY>.
You are receiving this because you authored the thread.Message ID:
***@***.***>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
