jkesselm commented on PR #1:
URL: https://github.com/apache/xalan-test/pull/1#issuecomment-1542693920
Absolutely agree about squash merge. Especially since hit can squash as part
of the merge. Making each merge self-contained is clearly a win.
And, yeah, let the messages float with just a plea that they be readable
descriptions of the intent. I'm willing to accept anything from "doc" on a
comment-only change to an essay with citations on why a functional change is
needed, with most in the middle somewhere... I just want to be able to look at
the history and make a reasonable guess about which change might be involved in
any given issue. Including the Jira issue number is always good too, but I'm
willing to trust common sense to apply.
--
/_ Joe Kesselman (he/him/his)
-/ _) My Alexa skill for New Music/New Sounds fans:
/ https://www.amazon.com/dp/B09WJ3H657/
() Plaintext Ribbon Campaign
/\ Stamp out HTML mail!
________________________________
From: Elliotte Rusty Harold ***@***.***>
Sent: Wednesday, May 10, 2023 2:36:56 PM
To: apache/xalan-test ***@***.***>
Cc: Joe Kesselman ***@***.***>; Author ***@***.***>
Subject: Re: [apache/xalan-test] Move tests/2.7.3 into main test driver
framework, document bugzilla test status (PR #1)
I'm OK with this being merged though formatting guidelines are one of many
things we should deal with sooner rather than later, and certainly in advance
of any significant feature work. I approved this a while back. I don't know who
can merge this or under what conditions.
Which reminds me, another decision we should be explicit about is merges and
commit history. I am very strongly in favor of squash merges only, and
configuring the Github repo to mandate that. One PR == one git commit.
I even more strongly want to avoid any particular rules about formatting of
git commit messages. They're a huge amount of extra hassle for no particular
benefit in my experience.
—
Reply to this email directly, view it on
GitHub<https://github.com/apache/xalan-test/pull/1#issuecomment-1542639314>, or
unsubscribe<https://github.com/notifications/unsubscribe-auth/A7OJ6W4CZMUJHFEESDSE5GLXFPN4RANCNFSM6AAAAAAXNHL2SY>.
You are receiving this because you authored the thread.Message ID:
***@***.***>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@xalan.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@xalan.apache.org
For additional commands, e-mail: dev-h...@xalan.apache.org
