elharo commented on PR #1: URL: https://github.com/apache/xalan-test/pull/1#issuecomment-1542639314
I'm OK with this being merged though formatting guidelines are one of many things we should deal with sooner rather than later, and certainly in advance of any significant feature work. I approved this a while back. I don't know who can merge this or under what conditions. Which reminds me, another decision we should be explicit about is merges and commit history. I am very strongly in favor of squash merges only, and configuring the Github repo to mandate that. One PR == one git commit. I even more strongly want to avoid any particular rules about formatting of git commit messages. They're a huge amount of extra hassle for no particular benefit in my experience. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@xalan.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@xalan.apache.org For additional commands, e-mail: dev-h...@xalan.apache.org
