chabala commented on code in PR #101: URL: https://github.com/apache/xalan-java/pull/101#discussion_r1359508298
########## pom.xml: ########## @@ -0,0 +1,194 @@ +<?xml version="1.0" encoding="UTF-8" standalone="no"?> +<project xmlns="http://maven.apache.org/POM/4.0.0"; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 https://maven.apache.org/xsd/maven-4.0.0.xsd";> + <packaging>pom</packaging> + <!-- KNOWN ISSUES: + "Production" jar/tar files? + Doclet and taglet (taglet working, but only for ./xalan?) + stylebook (currenly, see stylebook.docgen.sh) + + xalan-test compatibility/success/submodule + + NOTE: To get dependency tree from a multi-module project, use the + command "mvn compile dependency:tree" so everything is in scope. + --> + + <modelVersion>4.0.0</modelVersion> + <groupId>apache-xalan-j-2.7.3-maint-main</groupId> + <artifactId>apache-xalan-j-2.7.3-maint-main</artifactId> Review Comment: This is probably not what you want for your parent coordinates. Considering your existing artifacts at [xalan:xalan](https://search.maven.org/artifact/xalan/xalan/2.7.3/jar), your groupId should probably stay `xalan`, for everything, and neither should embed a version, it has a separate version field. I would suggest artifactId be `xalan-parent` here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@xalan.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@xalan.apache.org For additional commands, e-mail: dev-h...@xalan.apache.org
