jkesselm commented on code in PR #101: URL: https://github.com/apache/xalan-java/pull/101#discussion_r1359658432
########## pom.xml: ########## @@ -0,0 +1,194 @@ +<?xml version="1.0" encoding="UTF-8" standalone="no"?> +<project xmlns="http://maven.apache.org/POM/4.0.0"; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 https://maven.apache.org/xsd/maven-4.0.0.xsd";> + <packaging>pom</packaging> + <!-- KNOWN ISSUES: + "Production" jar/tar files? + Doclet and taglet (taglet working, but only for ./xalan?) + stylebook (currenly, see stylebook.docgen.sh) + + xalan-test compatibility/success/submodule + + NOTE: To get dependency tree from a multi-module project, use the + command "mvn compile dependency:tree" so everything is in scope. + --> + + <modelVersion>4.0.0</modelVersion> + <groupId>apache-xalan-j-2.7.3-maint-main</groupId> + <artifactId>apache-xalan-j-2.7.3-maint-main</artifactId> Review Comment: I think I'd favor xalan-project over xalan-parent. The intent really is that these really are owned and maintained by a single Apache project/team. I'm also wondering whether the group ID should really be xalan as it has been, versus org.apache.xalan or even org.apache. I don't know what the convention has been for other Apache projects, but as I understand the Maven semantics group ID should, ideally, reflect the group responsible for the package's development and maintenance. Yes, Maven Central has a field for that, and the Java package names also communicate that, but this still seems the right way to organize the Maven packaging namespace. (xalan:xalan seems redundant, which helps push me in this direction.) Am I misunderstanding Maven intent, or Maven practice? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@xalan.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@xalan.apache.org For additional commands, e-mail: dev-h...@xalan.apache.org
