chabala commented on code in PR #101: URL: https://github.com/apache/xalan-java/pull/101#discussion_r1359606963
########## pom.xml: ########## @@ -0,0 +1,194 @@ +<?xml version="1.0" encoding="UTF-8" standalone="no"?> +<project xmlns="http://maven.apache.org/POM/4.0.0"; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 https://maven.apache.org/xsd/maven-4.0.0.xsd";> + <packaging>pom</packaging> + <!-- KNOWN ISSUES: + "Production" jar/tar files? + Doclet and taglet (taglet working, but only for ./xalan?) + stylebook (currenly, see stylebook.docgen.sh) + + xalan-test compatibility/success/submodule + + NOTE: To get dependency tree from a multi-module project, use the + command "mvn compile dependency:tree" so everything is in scope. + --> + + <modelVersion>4.0.0</modelVersion> + <groupId>apache-xalan-j-2.7.3-maint-main</groupId> + <artifactId>apache-xalan-j-2.7.3-maint-main</artifactId> Review Comment: > It looks like Maven generates a Version class for the latter, which we could wrap our existing Version interface around...? I'm not sure what this means. Is the existing Xalan build generating some Version interface to make the artifact version discoverable programmatically? I can tell you that Maven artifacts are versioned, and a parent pom is versioned like an independent artifact. (One could build and publish a parent pom in a separate project, for instance, and then refer to it from many projects.) But, if you set 2.7.3 as the version on the parent pom, and don't specify different artifact versions in the module poms, they will all use the parent pom version at build time. Multi-module builds can be complex and tricky, so some reading is recommended: https://maven.apache.org/guides/mini/guide-multiple-modules.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@xalan.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@xalan.apache.org For additional commands, e-mail: dev-h...@xalan.apache.org
