chabala commented on code in PR #101: URL: https://github.com/apache/xalan-java/pull/101#discussion_r1359665860
########## pom.xml: ########## @@ -0,0 +1,194 @@ +<?xml version="1.0" encoding="UTF-8" standalone="no"?> +<project xmlns="http://maven.apache.org/POM/4.0.0"; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 https://maven.apache.org/xsd/maven-4.0.0.xsd";> + <packaging>pom</packaging> + <!-- KNOWN ISSUES: + "Production" jar/tar files? + Doclet and taglet (taglet working, but only for ./xalan?) + stylebook (currenly, see stylebook.docgen.sh) + + xalan-test compatibility/success/submodule + + NOTE: To get dependency tree from a multi-module project, use the + command "mvn compile dependency:tree" so everything is in scope. + --> + + <modelVersion>4.0.0</modelVersion> + <groupId>apache-xalan-j-2.7.3-maint-main</groupId> + <artifactId>apache-xalan-j-2.7.3-maint-main</artifactId> Review Comment: > I think I'd favor xalan-project over xalan-parent. Okay. `*-parent` is just frequently used, and I'd say more idiomatic for parent poms. For example: https://github.com/apache/maven-resolver/blob/master/pom.xml#L25 > I'm also wondering whether the group ID should really be xalan as it has been, versus org.apache.xalan or even org.apache. Since xalan already has artifacts published at Maven Central, I'd suggest maintaining the existing coordinates. If you do change the groupId, it would be more conventional to follow the reverse domain pattern: https://central.sonatype.org/publish/requirements/coordinates/ But xalan has essentially been grandfathered in with an old groupId, from when folks were just using their project name as a group, e.g. [junit:junit](https://search.maven.org/artifact/junit/junit/4.13.2/jar). If you change it now, you'll need to do more work to make sure Maven knows both sets of coordinates are the same artifact so dependency resolution will work for downstream users. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@xalan.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@xalan.apache.org For additional commands, e-mail: dev-h...@xalan.apache.org
