jkesselm commented on code in PR #106: URL: https://github.com/apache/xalan-java/pull/106#discussion_r1364503300
########## .github/workflows/main.yml: ########## @@ -0,0 +1,51 @@ +name: CI + +on: + push: + branches: + - '*' + pull_request: + branches: + - '*' + +permissions: + contents: read + +# https://help.github.com/en/actions/automating-your-workflow-with-github-actions/software-installed-on-github-hosted-runners +# GitHub Actions does not support Docker, PostgreSQL server on Windows, macOS :( + +concurrency: + # On master/release, we don't want any jobs cancelled so the sha is used to name the group + # On PR branches, we cancel the job if new commits are pushed + # More info: https://stackoverflow.com/a/68422069/253468 + group: ${{ github.ref == 'refs/heads/trunk' && format('ci-main-{0}', github.sha) || format('ci-main-{0}', github.ref) }} + cancel-in-progress: true + +jobs: + build: + name: 'Java 8' + runs-on: ubuntu-latest + steps: + - name: 'Checkout xalan-java' + uses: actions/checkout@v3 + - name: 'Set up JDK 8' + uses: actions/setup-java@v2 + with: + distribution: zulu + java-version: 8 + - name: 'Build Xalan jars' + run: | + ant jar + - uses: actions/checkout@v3 + name: 'Checkout xalan-test' + with: + repository: apache/xalan-test + path: xalan-test + ref: xalan-j_2_7_x + - name: 'Run xalan-test tests' + working-directory: xalan-test Review Comment: If the tests work fine when we invoke them as per our usual process, and don't work fine under CI, then CI is invoking them incorrectly. Yes, I am going to propose moving the tests into xalan-java so it's a more standard maven package and the default CI test setup should then work, but that's not yet on the table. We should either make CI replicate our current development environment well enough to run the regression tests as they are designed to be invoked, or turn off CI again until that can be done. During development, xalan-test is currently a separate project cloned as a sibling of xalan-java. In our old distribution jars, xalan-test was shipped as a subdirectory of xalan-java. Our development test drivers set up paths which should allow tests to be executed from either location. I'd need to look at exactly what CI is doing, but @stanio 's analysis sounds entirely plausible. And, yes, this gets fixed by a new PR, just like any other fix of code after it has been checked in. Nothing unusual about it, other than that we ideally should have tested better before accepting it for merge. Bugs happen. Bugs get fixed. Business as usual. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@xalan.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@xalan.apache.org For additional commands, e-mail: dev-h...@xalan.apache.org
