stanio commented on code in PR #106: URL: https://github.com/apache/xalan-java/pull/106#discussion_r1364865241
########## .github/workflows/main.yml: ########## @@ -0,0 +1,51 @@ +name: CI + +on: + push: + branches: + - '*' + pull_request: + branches: + - '*' + +permissions: + contents: read + +# https://help.github.com/en/actions/automating-your-workflow-with-github-actions/software-installed-on-github-hosted-runners +# GitHub Actions does not support Docker, PostgreSQL server on Windows, macOS :( + +concurrency: + # On master/release, we don't want any jobs cancelled so the sha is used to name the group + # On PR branches, we cancel the job if new commits are pushed + # More info: https://stackoverflow.com/a/68422069/253468 + group: ${{ github.ref == 'refs/heads/trunk' && format('ci-main-{0}', github.sha) || format('ci-main-{0}', github.ref) }} + cancel-in-progress: true + +jobs: + build: + name: 'Java 8' + runs-on: ubuntu-latest + steps: + - name: 'Checkout xalan-java' + uses: actions/checkout@v3 + - name: 'Set up JDK 8' + uses: actions/setup-java@v2 + with: + distribution: zulu + java-version: 8 + - name: 'Build Xalan jars' + run: | + ant jar + - uses: actions/checkout@v3 + name: 'Checkout xalan-test' + with: + repository: apache/xalan-test + path: xalan-test + ref: xalan-j_2_7_x + - name: 'Run xalan-test tests' + working-directory: xalan-test Review Comment: > I've suggested/meant fixing it on the `xalan-j_2_7_1_maint` branch by means of additional PR/commit. @vlsi, care to provide a fix for your original contribution? I don't have experience with Github Actions, but I've tried the second option (adjusting the final build command) works in my fork: stanio/xalan-java@a62bf319d0e01a0d30b15e35d3ac9a593fcb4dc0. I haven't been able to make it check out `xala-java` and `xalan-test` as sibling directories – is it possible with Github Actions? ########## .github/workflows/main.yml: ########## @@ -0,0 +1,51 @@ +name: CI + +on: + push: + branches: + - '*' + pull_request: + branches: + - '*' + +permissions: + contents: read + +# https://help.github.com/en/actions/automating-your-workflow-with-github-actions/software-installed-on-github-hosted-runners +# GitHub Actions does not support Docker, PostgreSQL server on Windows, macOS :( + +concurrency: + # On master/release, we don't want any jobs cancelled so the sha is used to name the group + # On PR branches, we cancel the job if new commits are pushed + # More info: https://stackoverflow.com/a/68422069/253468 + group: ${{ github.ref == 'refs/heads/trunk' && format('ci-main-{0}', github.sha) || format('ci-main-{0}', github.ref) }} + cancel-in-progress: true + +jobs: + build: + name: 'Java 8' + runs-on: ubuntu-latest + steps: + - name: 'Checkout xalan-java' + uses: actions/checkout@v3 + - name: 'Set up JDK 8' + uses: actions/setup-java@v2 + with: + distribution: zulu + java-version: 8 + - name: 'Build Xalan jars' + run: | + ant jar + - uses: actions/checkout@v3 + name: 'Checkout xalan-test' + with: + repository: apache/xalan-test + path: xalan-test + ref: xalan-j_2_7_x + - name: 'Run xalan-test tests' + working-directory: xalan-test Review Comment: > I've suggested/meant fixing it on the `xalan-j_2_7_1_maint` branch by means of additional PR/commit. @vlsi, care to provide a fix for your original contribution? I don't have experience with Github Actions, but I've tried the second option (adjusting the final build command) works in my fork: stanio/xalan-java@a62bf319d0e01a0d30b15e35d3ac9a593fcb4dc0. I haven't been able to make it check out `xala-java` and `xalan-test` as sibling directories – is it possible with Github Actions? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@xalan.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@xalan.apache.org For additional commands, e-mail: dev-h...@xalan.apache.org
