kriegaex commented on PR #133: URL: https://github.com/apache/xalan-java/pull/133#issuecomment-1836458546
> If the resource is missing, then `getResourceAsStream` returns `null`, and there's a test for that. Conceded. Anyway, it is an I/O operation, and something can go wrong there, if not in the specific JDK version you are currently looking at, then in another. We know how long-lived old Xalan code was. We are talking decades here, not just years. I do not see any reasonto take any unnecessary risks here, putting an unprotected I/O operation into a static block. It is called defensive programming. Maybe you heard the term. I am not going to change the application code, hence also not the test covering same code. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@xalan.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@xalan.apache.org For additional commands, e-mail: dev-h...@xalan.apache.org
