kriegaex commented on PR #133: URL: https://github.com/apache/xalan-java/pull/133#issuecomment-1837022359
> If this is not an expected exception, I would have expected the test to report a failure. But it **is** an expected exception. Covering the code handling this exception is the whole point of the negative test. Hence, the exception to be logged is exactly what is supposed to happen here, and the test passes. I said all of this before, and maybe you also want to review the tests themselves, not just the console log. > If this is an expected/correct exception, the testcase should trap it and report it correctly handled It **is** correctly handled by the version class. What that class does it to log the exception to stdErr, but handle the problem gracefully, returning a version 0.0.0 in case the unthinkable happens that the resource file cannot be found or parsed correctly. > rather than letting it output to console, right? Wrong. The only way to suppress that test from logging to stdErr would be to redirect stdErr for the duration of the test, and like I also said before, this makes the test not thread-safe. Tests can be run in parallel. Please read what I talked about with Vladimir, all your questions are already answered, I am repeating myself here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@xalan.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@xalan.apache.org For additional commands, e-mail: dev-h...@xalan.apache.org
