jkesselm commented on PR #133:
URL: https://github.com/apache/xalan-java/pull/133#issuecomment-1836632327
I merged onto my local directory, ran `mvn clean package site` on my Java 8
setup.
org.apache.xalan.VersionTest is reporting:
```
[INFO] Tests run: 13, Failures: 0, Errors: 0, Skipped: 0, Time elapsed:
0.250 s -- in org.apache.xalan.processor.XSLProcessorVersionTest
[INFO] Running org.apache.xalan.VersionTest
java.lang.RuntimeException: Cannot read properties file to extract Xalan
version number information:
at org.apache.xalan.Version.readVersionNumber(Version.java:63)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
[... etc, etc, etc]
Caused by: java.lang.NullPointerException
```
However, the test does report success. This confuses me.
If this is not an expected exception, I would have expected the test to
report a failure.
If this is an expected/correct exception, the testcase should trap it and
report it correctly handled, rather than letting it output to console, right?
That's how I've always seen tests of expected exceptions handled; as with other
output, if it's correct it doesn't need to be logged. You're welcome to
disagree, but if so I'm probably going to come back and change it after the PR.
Just want to make sure we agree on what the PR is expected to be doing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@xalan.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@xalan.apache.org
For additional commands, e-mail: dev-h...@xalan.apache.org
