vlsi commented on PR #133: URL: https://github.com/apache/xalan-java/pull/133#issuecomment-1836464280
> Question: Do the log lines "eat any bread", as we say in German? They do. Frankly, if CI fails (e.g. due to a failed test), I typically scroll the log to check the failure. The current 5900 lines are hard to scroll even with my quite powerful notebook. I wish the lines like "Generating /home/runner/work/xalan-java/xalan-java/target/site/apidocs" were never there. They are never helpful. --- > Anyway, it is an I/O operation, and something can go wrong there Please, IO operations throw `IOException`. `Class.getResourceAsStream` is not an IO operation. It is a request to fetch the resource, and it is up to classloader if the operation is IO or not. The documentation (==specification) for `getResourceAsStream` is quite clear that is shoult not throw exceptions, so discussing "unexpected exceptions from getResourceAsStream" does not sound right to me. Remember: we are not reading the stream there. We just locate it. It should either return or return null. That is it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@xalan.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@xalan.apache.org For additional commands, e-mail: dev-h...@xalan.apache.org
