I've brought additional minor discussion. What is the advantage of minifying & obfuscating css & javascripts in Zeppelin-web?
In my thought it just delay build time and make web-debugging harder. If it's true, why don't we get rid of minifying & obfuscating task?? Any thoughts? On Fri Feb 06 2015 at 2:24:57 PM Kevin Kim (Sangwoo) <[email protected]> wrote: > Thanks! I'll try to start some work on there. > > On Fri Feb 06 2015 at 2:24:08 PM Alex B. <[email protected]> wrote: > >> If that would be of any help, please feel free to use this branch >> https://github.com/NFLabs/zeppelin/pull/321 >> >> On Thu, Feb 5, 2015 at 6:54 PM, Kevin Kim (Sangwoo) <[email protected]> >> wrote: >> >> > @Anthony >> > I found a PR implementing ts angular generator in yeoman project, not >> very >> > sure it will work or not. >> > https://github.com/yeoman/generator-angular/pull/539 >> > Would you look at it? >> > >> > @Alex, >> > Yes, tough it seems we have some challenges like code-generating by >> yeoman >> > as Anthony raised, >> > Many guys are positive on Typescript, I guess it worths to try at least. >> > >> > I guess frontend building script is Alex or Anthony's specialties, can >> you >> > guys open a branch and let me start work on it? >> > Or I will try modifying build script in case you are busy. >> > >> > Regards, >> > Kevin >> > >> > >> > On Thu Feb 05 2015 at 10:27:05 AM Anthony Corbacho < >> > [email protected]> wrote: >> > >> > > Currently we are using yoman to create angular directive,service >> etcetc. >> > > basicaly what i do is something like yo angular:directive mydirective, >> > then >> > > yo man will create the directive.js under script directive and also >> the >> > > directive test and update the index.html and all other stuff. >> > > >> > > Will it be possible to generate in the same way the ts file? if not i >> am >> > > not favorable for a switch. >> > > >> > > On Thu, Feb 5, 2015 at 10:12 AM, Alex B. <[email protected]> >> wrote: >> > > >> > > > Kevin, Eran, Moon, Damien - thank you for listing a good points >> about >> > > > tooling, support of the vanila JS and angular! >> > > > >> > > > Through this thread it looks like Zeppelin project is ready to >> accept >> > > > Typescript contributions, starting with frontend build script >> update. >> > Is >> > > > that true? >> > > > >> > > > Then we also going to need some docs and examples to quickstart >> > frontend >> > > > development for future contributors to mitigate the issue with >> > knowledge >> > > > transfer that Moon brought. >> > > > >> > > > >> > > > On Wed, Feb 4, 2015 at 9:09 PM, Kevin (Sangwoo) Kim < >> > [email protected] >> > > > >> > > > wrote: >> > > > >> > > > > Eran, thanks for great informations! Definitely it would help! >> > > > > >> > > > > Moon, >> > > > > I can agree that the benefit from adopting Typescript is >> overwhelming >> > > the >> > > > > learning costs. (I guess cost would be quite small enough, it's >> > > simple!) >> > > > > >> > > > > Alex >> > > > > AtScript also seems great, we can discuss it later like Moon said. >> > > > > >> > > > > Facebook Flow, has same purpose to Typescript and has similar >> > > popularity. >> > > > > But Flow will throw error on every line if we don't modify our >> whole >> > js >> > > > > codes. Also Typescript goes better with Angular js than Flow. >> > > > > >> > > > > >> > > > > >> > > > > >> > > > > On Wed Feb 04 2015 at 4:38:23 PM IT CTO <[email protected]> >> wrote: >> > > > > >> > > > > > If I can add my 2 cents here... >> > > > > > AFAIK Palantir has chose typescript for their web version and >> > > developed >> > > > > > some opensource tool to help the process. this include the >> > following: >> > > > > > A linter for the TypeScript language. >> > > > > > An Eclipse plug-in for linting TypeScript code. >> > > > > > A Grunt plugin for tslint. >> > > > > > An Eclipse plug-in for developing in the TypeScript language. >> > > > > > >> > > > > > All of the above available on github at >> > https://github.com/palantir >> > > > > > >> > > > > > HTH, >> > > > > > Eran >> > > > > > >> > > > > > On Wed, Feb 4, 2015 at 8:58 AM, moon soo Lee <[email protected]> >> > > wrote: >> > > > > > >> > > > > > > One thing we have to think about is, it'll require current >> > > > contributors >> > > > > > and >> > > > > > > future contributors additional knowledge. ie. Understanding >> > > > Typescript. >> > > > > > > >> > > > > > > So the question from me is, Are the benefits that Typescript >> > > bringing >> > > > > > large >> > > > > > > enough to negate the burden that current+future contributors >> > > > understand >> > > > > > > typescript? >> > > > > > > >> > > > > > > To me, probably yes. I've look through Typescript and i could >> > > > > understand >> > > > > > > quickly and i can see how much it'll be helpful for the >> project. >> > > > > > > >> > > > > > > >> > > > > > > About AtScript, I think it's not widely used compare to >> > Typescript( >> > > > > > > http://www.google.com/trends/explore#q=typescript%2C% >> > > > > > 20atscript&cmpt=q&tz= >> > > > > > > ). >> > > > > > > While AtScript is superset of Typescript, I think it's safe to >> > > > discuss >> > > > > > > about using it after we adopt Typescript. >> > > > > > > >> > > > > > > Best, >> > > > > > > moon >> > > > > > > >> > > > > > > >> > > > > > > >> > > > > > > >> > > > > > > On Wed, Feb 4, 2015 at 2:51 PM, Kevin Kim (Sangwoo) < >> > > > [email protected]> >> > > > > > > wrote: >> > > > > > > >> > > > > > > > @Alex and Damien, >> > > > > > > > Great point! >> > > > > > > > Cannot agree more the new system must go well with Angular >> js. >> > > > > > > > >> > > > > > > > For Angular js, >> > > > > > > > look at this project: >> > > > > > > > >> > > > https://github.com/borisyankov/DefinitelyTyped/tree/master/ >> angularjs >> > > > > > > > >> > > > > > > > it defines Angular modules into Typescripts. >> > > > > > > > In our company, there are two project using Angular + >> > Typescript >> > > > > using >> > > > > > > > the DefinitelyTyped, >> > > > > > > > maybe I can bring some know-hows on that. >> > > > > > > > >> > > > > > > > @Damien >> > > > > > > > One good point of Typescript is, they will not throw any >> errors >> > > > when >> > > > > we >> > > > > > > > move onto them. If we have no type on code, it work just >> like a >> > > > > > > > javascript. (As >> > > > > > > > I already mentioned, it just work if we change xx.js -> >> xx.ts, >> > > just >> > > > > > > > changing the filename) >> > > > > > > > You can have some simple tutorial on that here. >> > > > > > > > http://www.typescriptlang.org/Tutorial >> > > > > > > > >> > > > > > > > Also building Typescript goes well with Grunt, I'm attaching >> > > build >> > > > > file >> > > > > > > > we're using. >> > > > > > > > >> > > > > > > > Gruntfile.js >> > > > > > > > === >> > > > > > > > module.exports = function(grunt) { >> > > > > > > > >> > > > > > > > // Project configuration. >> > > > > > > > grunt.initConfig({ >> > > > > > > > pkg: grunt.file.readJSON('package.json'), >> > > > > > > > watch : { >> > > > > > > > scripts: { >> > > > > > > > files: ['sticker/static/ts/**/*.ts'], >> > > > > > > > tasks: ['typescript'], >> > > > > > > > options: { >> > > > > > > > spawn: false >> > > > > > > > } >> > > > > > > > } >> > > > > > > > }, >> > > > > > > > typescript: { >> > > > > > > > build: { >> > > > > > > > src : ['sticker/static/ts/**/*.ts'], >> > > > > > > > dest : 'sticker/static/js/', >> > > > > > > > options: { >> > > > > > > > mudule : 'amd', >> > > > > > > > target: 'es3', >> > > > > > > > sourceMap: false, >> > > > > > > > basePath : 'sticker/static/ts' >> > > > > > > > } >> > > > > > > > } >> > > > > > > > } >> > > > > > > > }); >> > > > > > > > >> > > > > > > > >> > > > > > > > grunt.loadNpmTasks('grunt-typescript'); >> > > > > > > > >> > > > > > > > // Load the plugin that provides the "watch" task. >> > > > > > > > grunt.loadNpmTasks('grunt-contrib-watch'); >> > > > > > > > >> > > > > > > > // Default task(s). >> > > > > > > > grunt.registerTask('default', ['typescript']); >> > > > > > > > >> > > > > > > > }; >> > > > > > > > >> > > > > > > > >> > > > > > > > >> > > > > > > > >> > > > > > > > >> > > > > > > > >> > > > > > > > >> > > > > > > > On Wed Feb 04 2015 at 2:38:54 PM Corneau Damien < >> > > > > [email protected]> >> > > > > > > > wrote: >> > > > > > > > >> > > > > > > > > I think it can be included if it matches multiple >> conditions: >> > > > > > > > > - Has to be angularjs ready >> > > > > > > > > - Has to be easy to set up (currently we are mainly using >> > > yeoman >> > > > to >> > > > > > > > create >> > > > > > > > > new controllers etc..) >> > > > > > > > > - Has to fit inside of our build and dev Grunt rules >> > > > > > > > > >> > > > > > > > > Not a big fan of adding changes that big just to add the >> var >> > > > types >> > > > > > into >> > > > > > > > the >> > > > > > > > > code, one thing I'm scared is: Will it pop errors >> everywhere >> > > once >> > > > > > it's >> > > > > > > > > activated? (because of missing types?) >> > > > > > > > > >> > > > > > > > > IDE support is not that important since you can always >> tell >> > > your >> > > > > > editor >> > > > > > > > to >> > > > > > > > > use javascript highlighting and work without >> auto-completion. >> > > > > > > > > >> > > > > > > > > >> > > > > > > > > On Wed, Feb 4, 2015 at 2:07 PM, Alex B. <[email protected]> >> > > wrote: >> > > > > > > > > >> > > > > > > > > > Having types always strike as a good idea to me, thanks >> for >> > > > > > bringing >> > > > > > > > this >> > > > > > > > > > discussion! >> > > > > > > > > > >> > > > > > > > > > Just to understand the ground better: typescript is >> made by >> > > > > > microsoft >> > > > > > > > and >> > > > > > > > > > AFAIK there are other implementations like Flow >> > > > > > > > > > <https://github.com/facebook/flow> from Facebook and >> > > AtScript >> > > > > from >> > > > > > > > > Google >> > > > > > > > > > (part of Angular, superset of Typescript, brings >> > annotations >> > > > too) >> > > > > > > > > > >> > > > > > > > > > I wonder, should we also consider alignment with >> angular as >> > > an >> > > > > > > > important >> > > > > > > > > > point for whatever alternative we look at? >> > > > > > > > > > >> > > > > > > > > > >> > > > > > > > > > On Wed, Feb 4, 2015 at 12:51 PM, Kevin (Sangwoo) Kim < >> > > > > > > > > [email protected]> >> > > > > > > > > > wrote: >> > > > > > > > > > >> > > > > > > > > > > Hello developers, >> > > > > > > > > > > >> > > > > > > > > > > I'd like to open a discussion on getting Typescript >> into >> > > > > > zeppelin. >> > > > > > > > > > > >> > > > > > > > > > > http://www.typescriptlang.org/ >> > > > > > > > > > > >> > > > > > > > > > > Typescript brings type system onto javascript codes, >> > which >> > > > > > improves >> > > > > > > > > > > productivity working with huge js codes. >> > > > > > > > > > > >> > > > > > > > > > > One of the really good point of Typescript is, 100% >> > > > > compatibility >> > > > > > > > with >> > > > > > > > > > > javascript, that is, >> > > > > > > > > > > if we just change xxx.js into xxx.ts, it just works. >> > > > > > > > > > > Then we can add some classes and type annotation >> > gradually. >> > > > > > > > > > > >> > > > > > > > > > > Some frontend guys in our company already compared >> > similar >> > > > > > > technology >> > > > > > > > > > like >> > > > > > > > > > > coffeescript and finally using Typescript and they are >> > > really >> > > > > > > > > satisfied. >> > > > > > > > > > > >> > > > > > > > > > > On the other hand, IDE support could be a limitation >> of >> > > > > > Typescript. >> > > > > > > > > > > IntelliJ ultimate edition ($199) or Visual Studio can >> be >> > > used >> > > > > to >> > > > > > > > > utilize >> > > > > > > > > > > full editing feature of Typescript (auto completion, >> etc) >> > > > > > > > > > > I can confirm syntax highlighting feature for >> Typescript >> > > > works >> > > > > on >> > > > > > > > > Sublime >> > > > > > > > > > > editor. >> > > > > > > > > > > (Of course you can use any editor or IDE to edit ts, >> > > tough.) >> > > > > > > > > > > >> > > > > > > > > > > Any idea on this topic is welcomed! >> > > > > > > > > > > >> > > > > > > > > > > Regards, >> > > > > > > > > > > Kevin >> > > > > > > > > > > >> > > > > > > > > > >> > > > > > > > > >> > > > > > > > >> > > > > > > >> > > > > > >> > > > > > >> > > > > > >> > > > > > -- >> > > > > > Eran | CTO >> > > > > > >> > > > > >> > > > >> > > > >> > > > >> > > > -- >> > > > -- >> > > > Kind regards, >> > > > Alexander. >> > > > >> > > >> > >> >
