[
https://issues.apache.org/jira/browse/ZOOKEEPER-836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12936099#action_12936099
]
Benjamin Reed commented on ZOOKEEPER-836:
-----------------------------------------
this looks great thomas! i really like the HostProvider class. There is one
change i would like you to make. (or i can make it if you are okay with it.)
the IllegalConstructorArgumentException is a bit gratuitous. especially since
it will be changed to an IllegalArgumentException later. could you just make
that an IllegalConstructorArgumentException so that we can avoid class
proliferation?
> hostlist as string
> ------------------
>
> Key: ZOOKEEPER-836
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-836
> Project: ZooKeeper
> Issue Type: Sub-task
> Components: java client
> Affects Versions: 3.3.1
> Reporter: Patrick Datko
> Assignee: Thomas Koch
> Attachments: ZOOKEEPER-836.patch, ZOOKEEPER-836.patch
>
>
> The hostlist is parsed in the ctor of ClientCnxn. This violates the rule of
> not doing (too much) work in a ctor. Instead the ClientCnxn should receive an
> object of class "HostSet". HostSet could then be instantiated e.g. with a
> comma separated string.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
