[
https://issues.apache.org/jira/browse/ZOOKEEPER-836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12964506#action_12964506
]
Thomas Koch commented on ZOOKEEPER-836:
---------------------------------------
I've found this article from ibm developerworks about the pros and cons of
checked vs. unchecked exceptions:
http://www.ibm.com/developerworks/java/library/j-jtp05254.html
I believe it supports my case for checked exceptions in this patch. Maybe I
should provide more specific exceptions?
I couldn't find a preference toward either checked or unchecked exceptions in
the http://wiki.apache.org/hadoop/CodeReviewChecklist
I know only of this mail which suggests phunt's preference of checked
exceptions:
http://www.mail-archive.com/[email protected]/msg00920.html
> hostlist as string
> ------------------
>
> Key: ZOOKEEPER-836
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-836
> Project: ZooKeeper
> Issue Type: Sub-task
> Components: java client
> Affects Versions: 3.3.1
> Reporter: Patrick Datko
> Assignee: Thomas Koch
> Attachments: ZOOKEEPER-836.patch, ZOOKEEPER-836.patch
>
>
> The hostlist is parsed in the ctor of ClientCnxn. This violates the rule of
> not doing (too much) work in a ctor. Instead the ClientCnxn should receive an
> object of class "HostSet". HostSet could then be instantiated e.g. with a
> comma separated string.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
