[
https://issues.apache.org/jira/browse/ZOOKEEPER-836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12964791#action_12964791
]
Benjamin Reed commented on ZOOKEEPER-836:
-----------------------------------------
i agree, we should use checked exceptions. most, if not all, of the exceptions
we have added are checked exceptions. still we have to adapt to the world in
which we live. Thread.sleep() should not throw a checked exception, but it
does. i'm not going to write a new class to fix that. IllegalArgumentException
works perfectly here. maybe it should have been a checked exception, but it's
not. let's just use it and move on. i know class proliferation is not an issue
for you, but it is for some of us.
> hostlist as string
> ------------------
>
> Key: ZOOKEEPER-836
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-836
> Project: ZooKeeper
> Issue Type: Sub-task
> Components: java client
> Affects Versions: 3.3.1
> Reporter: Patrick Datko
> Assignee: Thomas Koch
> Attachments: ZOOKEEPER-836.patch, ZOOKEEPER-836.patch
>
>
> The hostlist is parsed in the ctor of ClientCnxn. This violates the rule of
> not doing (too much) work in a ctor. Instead the ClientCnxn should receive an
> object of class "HostSet". HostSet could then be instantiated e.g. with a
> comma separated string.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
