[
https://issues.apache.org/jira/browse/ZOOKEEPER-836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12964848#action_12964848
]
Patrick Hunt commented on ZOOKEEPER-836:
----------------------------------------
bq. I know only of this mail which suggests phunt's preference of checked
exceptions
I'm not a fan of "get rid of all checked exceptions", I believe they do have a
place. I did see a recent article (can't find it off hand) though that was
specifically talking about not using checked exceptions in public APIs due to
the fact that they change the signature. I see the wisdom in that -- except
when throwing an unchecked exception (in order to not break the API signature)
ends up breaking the semantics (say you start throwing an unchecked exception
that you expect the caller should naturally handle, not sure of use case/real
world example here...)
> hostlist as string
> ------------------
>
> Key: ZOOKEEPER-836
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-836
> Project: ZooKeeper
> Issue Type: Sub-task
> Components: java client
> Affects Versions: 3.3.1
> Reporter: Patrick Datko
> Assignee: Thomas Koch
> Attachments: ZOOKEEPER-836.patch, ZOOKEEPER-836.patch,
> ZOOKEEPER-836_2.patch
>
>
> The hostlist is parsed in the ctor of ClientCnxn. This violates the rule of
> not doing (too much) work in a ctor. Instead the ClientCnxn should receive an
> object of class "HostSet". HostSet could then be instantiated e.g. with a
> comma separated string.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
